Fix #7918 Root path spec #7919
Merged
Fix #7918 Root path spec #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle root pathspec in PathMappings.asPathSpec Signed-off-by: Greg Wilkins <[email protected]>
joakime
reviewed
Apr 26, 2022
| @Test | ||
| public void testAsPathSpec() | ||
| { | ||
| assertThat(PathMappings.asPathSpec(""), instanceOf(ServletPathSpec.class)); |
There was a problem hiding this comment.
What about asPathSpec(null), should that be interpreted as ROOT too?
There was a problem hiding this comment.
No, it is very precisely the empty string that matches "/" (and "/" matches everything - go figure!)
cleaner logic Signed-off-by: Greg Wilkins <[email protected]>
lorban
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle root pathspec in PathMappings.asPathSpec
Not used in jetty-9, but will be ported forward to where it is used in 10,11 & 12
Signed-off-by: Greg Wilkins [email protected]