Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathMappings.asPathSpec does not allow root ServletPathSpec #7918

Closed
gregw opened this issue Apr 26, 2022 · 2 comments · Fixed by #7920 or #7919
Closed

PathMappings.asPathSpec does not allow root ServletPathSpec #7918

gregw opened this issue Apr 26, 2022 · 2 comments · Fixed by #7920 or #7919
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Apr 26, 2022

Jetty version(s)
all

Description

The ServletPathSpec of "" (empty string) is the root only match. This is not allowed by PathMappings.asPathSpec, which can prevent code that does not explicitly use ServletPathSpec from matching root.

@gregw gregw added the Bug For general bugs on Jetty side label Apr 26, 2022
gregw added a commit that referenced this issue Apr 26, 2022
Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue Apr 26, 2022
Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue Apr 26, 2022
cleaner logic

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue Apr 26, 2022
cleaner logic

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw closed this as completed in e12d5d5 Apr 26, 2022
gregw added a commit that referenced this issue Apr 26, 2022
Fix #7918 Root path spec
Handle root pathspec in PathMappings.asPathSpec
Introduce protected asPathSpec to allow for extensibility

Signed-off-by: Greg Wilkins <[email protected]>
This was linked to pull requests Apr 26, 2022
@gregw
Copy link
Contributor Author

gregw commented Apr 26, 2022

merged to 10,11 & 12. Waiting for build for 9

@gregw gregw reopened this Apr 26, 2022
joakime pushed a commit that referenced this issue Apr 26, 2022
* Fix #7918 Root path spec

Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <[email protected]>
@joakime
Copy link
Contributor

joakime commented Apr 26, 2022

Fully merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants