Issue #5044 - Refactor of Jetty WebSocket Upgrade Request/Response #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
… to ClientUpgradeRequest Signed-off-by: Lachlan Roberts <[email protected]>
…uest Signed-off-by: Lachlan Roberts <[email protected]>
… API interfaces Signed-off-by: Lachlan Roberts <[email protected]>
…ty-websocket-server Signed-off-by: Lachlan Roberts <[email protected]>
joakime
reviewed
Jul 30, 2020
...socket/websocket-jetty-api/src/main/java/org/eclipse/jetty/websocket/api/UpgradeRequest.java
Show resolved
Hide resolved
joakime
reviewed
Jul 30, 2020
...ocket/websocket-jetty-api/src/main/java/org/eclipse/jetty/websocket/api/UpgradeResponse.java
Show resolved
Hide resolved
joakime
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
After a hangout review with @lachlan-roberts i'm good with this change as it stands.
+1 from me.
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
deleted the
jetty-10.0.x-5044-WebSocketUpgradeRequestResponse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5044
The Jetty WebSocket API Interfaces
UpgradeRequest,UpgradeResponsehave been simplified with some server specific methods being moved toJettyServerUpgradeRequestandJettyServerUpgradeResponsewhich are now interfaces which extend the API interface.This allowed me to remove all the empty and
UnsupportedOperationExceptionimplementations in the various implementations.