Unit Testing the Embedded Examples #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
+ Also made ContextHandler warning message about features that are unimplemented (and you should use ServletContextHandler) more clear. (this helped with diagnosing where the bug was in ServletHolder) Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
gregw
requested changes
Sep 10, 2019
examples/embedded/src/main/java/org/eclipse/jetty/embedded/ExampleServer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
+ Moved realm.properties to src/main/resources/etc/ + Ensured that surefire's useManifestOnlyJar=false to enable taglibs to be found, and jstl to work. Signed-off-by: Joakim Erdfelt <[email protected]>
gregw
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /examples/embedded/ code is starting show some bit-rot, so it's time to add testing to them.
I'm implementing a
createServer(int port)style method for each example that can be both used from themain(String args[])method with a static value (like8080) and also from junit testing with a port0(wildcard) for testing reasons.Signed-off-by: Joakim Erdfelt [email protected]