Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webapp artifacts for examples and tests #2992

Closed
gregw opened this issue Oct 17, 2018 · 7 comments
Closed

Use webapp artifacts for examples and tests #2992

gregw opened this issue Oct 17, 2018 · 7 comments
Assignees
Milestone

Comments

@gregw
Copy link
Contributor

gregw commented Oct 17, 2018

Lots of tests and examples are using relative paths to find webapps and keystores to run/test against. Examples include:

This is fragile and dependent on working directory, IDEs etc.

Instead, we should import webapps as maven artifacts and install them in a known location in target.

@gregw gregw added this to the 10.0.x milestone Oct 17, 2018
@gregw
Copy link
Contributor Author

gregw commented Oct 17, 2018

@olamy this feels like something you could tackle?

@olamy
Copy link
Member

olamy commented Oct 17, 2018

@gregw yup for sure.

@olamy
Copy link
Member

olamy commented Nov 21, 2018

starting working on it and found few examples broken/not maintained :)

@olamy
Copy link
Member

olamy commented Nov 26, 2018

depends on #3138

@stale
Copy link

stale bot commented Nov 26, 2019

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 26, 2019
@olamy
Copy link
Member

olamy commented Nov 26, 2019

definitely todo

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Nov 26, 2019
@joakime
Copy link
Contributor

joakime commented Nov 26, 2019

This was addressed in multiple commits.
First introduced with 862e6d0
Finished up in PR #4056

@joakime joakime closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants