Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copying base resources must happen when preparing packaging #3138

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

olamy
Copy link
Member

@olamy olamy commented Nov 23, 2018

we must not rely on id.
This was preventing having the logs directory within the distribution.

Signed-off-by: olivier lamy [email protected]

@olamy olamy requested review from jmcc0nn3ll and joakime November 23, 2018 07:59
@olamy olamy changed the title copying base resources must happen when preparing packaging we must n… copying base resources must happen when preparing packaging Nov 23, 2018
@olamy olamy force-pushed the fix_wrong_phase_for_jetty_dis_resources branch 2 times, most recently from 4dcaa03 to 180cefb Compare November 23, 2018 11:13
@olamy olamy force-pushed the fix_wrong_phase_for_jetty_dis_resources branch from 180cefb to a613b30 Compare November 24, 2018 23:31
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, LGTM

@olamy olamy merged commit bee1487 into jetty-9.4.x Nov 28, 2018
@olamy olamy deleted the fix_wrong_phase_for_jetty_dis_resources branch November 28, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants