Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Jetty module for HTTP/2 client dependencies #12063

Closed
sbordet opened this issue Jul 19, 2024 · 1 comment · Fixed by #12170
Closed

Introduce Jetty module for HTTP/2 client dependencies #12063

sbordet opened this issue Jul 19, 2024 · 1 comment · Fixed by #12170
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jul 19, 2024

Jetty version(s)
12

Jetty Environment
core

Description
When a web application is proxying and wants to use HTTP/2, it may need to have the HTTP/2 client dependencies provided by the server, rather than the webapp.

There currently is no module for HTTP/2 client, while there is for HTTP/1.

Following the suggestion from #12027, this new Jetty module should download the dependencies on-the-fly.
@sbordet sbordet added the Bug For general bugs on Jetty side label Jul 19, 2024
@joakime
Copy link
Contributor

joakime commented Jul 22, 2024

We have a client module already.
What would you call this new module? http2-client perhaps? (same for http3-client?)
What libs would you put in it?

@joakime joakime mentioned this issue Jul 22, 2024
Open
@sbordet sbordet self-assigned this Aug 18, 2024
sbordet added a commit that referenced this issue Aug 18, 2024
@sbordet
Fixes #12063 - Introduce Jetty module for HTTP/2 client dependencies.
7b8d3fa 
Made client.mod download dependencies via a [files] section.

Introduced http2-client.mod and http2-client-transport.mod.
These modules download dependencies via a [files] section.
They can be used to have the server provide the dependencies in case of a web application proxies request using HTTP/2.

Fixed ContentProvider to set the context ClassLoader before reading the Jetty XML context file, which may reference classes from the web application.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Aug 18, 2024 that will close this issue
Fixes #12063 - Introduce Jetty module for HTTP/2 client dependencies. #12170
Merged
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.13 - FROZEN Aug 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.13 - FROZEN Aug 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.13 - FROZEN Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.13 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #12063 - Introduce Jetty module for HTTP/2 client dependencies. jetty/jetty.project
2 participants
@joakime @sbordet