Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no org.eclipse.jetty.http2.client package in official jetty-12.0.11 download #12027

Closed
Quantum2Bits opened this issue Jul 11, 2024 · 5 comments
Labels
Bug For general bugs on Jetty side

Comments

@Quantum2Bits
Copy link

Jetty version(s)

Jetty Environment

Java version/vendor (use: java -version)

OS type/version

Description

In official download jetty-home-12.0.11 (also 12.0.10), there is no package org.eclipse.jetty.http2.client, as well packages org.eclipse.jetty.http2.client.transport, org.eclipse.jetty.http3.client, org.eclipse.jetty.http3.client.transport, and org.eclipse.jetty.quic.client

I download the source files, and manually compile theses packages. It works.

How to reproduce?

@Quantum2Bits Quantum2Bits added the Bug For general bugs on Jetty side label Jul 11, 2024
@sbordet
Copy link
Contributor

sbordet commented Jul 11, 2024

jetty-home provides Jetty as a standalone server, so typically the artifacts you refer to are not necessary in a server.

There is no need to download the source files and compile them, as they are available in Maven Central, so it is enough to add the dependencies and they will be downloaded.

Can you detail your use case, where you need those packages in a server environment?

@Quantum2Bits
Copy link
Author

I find the client jar files in Maven Central. Thank you.

I am try to improve the jetty proxy. The new proxy has a local part and a remote part. The remote part can only accept http request. it may prefer http/2 or http/3.

@joakime
Copy link
Contributor

joakime commented Jul 11, 2024

Closing as answered

@joakime joakime closed this as completed Jul 11, 2024
@sbordet
Copy link
Contributor

sbordet commented Jul 11, 2024

@joakime perhaps we should consider to add at least HTTP/2 client artifacts to jetty-home, given that the jetty-client is there.

In this way proxy apps can get the HTTP/2 classes provided by the server -- if we do it for HTTP/1, why not HTTP/2?

For HTTP/3 I would not bother, because it is experimental and not really well suited for a proxy.

@gregw
Copy link
Contributor

gregw commented Jul 16, 2024

@sbordet rather than always include them in the download, can we just have a module that downloads the http2 client jars and dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

4 participants