Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jsdom to latest (v26.0.0) #15481

Closed

Conversation

jeremy-daley-kr
Copy link

Summary

The initial motivation for this was simply to get rid of a deprecation notice from Node v22 about punycode:

punycode
  <- psl
    <- tough-cookie (replaces psl in v5.0.0)
      <- jsdom (upgrade gets that ^ replacement)

...But ultimately, we're talking about a 4-majors-behind package... so hopefully nothing blows up.

Test plan

Copy link

CLA Not Signed

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 39a18e9
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/679926b72c3bd10008d51845
😎 Deploy Preview https://deploy-preview-15481--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Smrtnyk
Copy link

Smrtnyk commented Jan 28, 2025

duplicate of #15473

@jeremy-daley-kr
Copy link
Author

duplicate of #15473

Oh! Nice... I'll look into the e2e snapshots thing he mentioned

@Smrtnyk
Copy link

Smrtnyk commented Jan 28, 2025

duplicate of #15473

Oh! Nice... I'll look into the e2e snapshots thing he mentioned

keep in mind that even that PR might not get accepted
#15417
due to node versions that jest supports

just something to consider before you invest more time

@jeremy-daley-kr
Copy link
Author

duplicate of #15473

Oh! Nice... I'll look into the e2e snapshots thing he mentioned

keep in mind that even that PR might not get accepted #15417 due to node versions that jest supports

just something to consider before you invest more time

Hmm. Is this a touchy subject? I'm trying to understand the attachment to a Node version (16) that's already reached end of life.

@Smrtnyk
Copy link

Smrtnyk commented Jan 28, 2025

duplicate of #15473

Oh! Nice... I'll look into the e2e snapshots thing he mentioned

keep in mind that even that PR might not get accepted #15417 due to node versions that jest supports
just something to consider before you invest more time

Hmm. Is this a touchy subject? I'm trying to understand the attachment to a Node version (16) that's already reached end of life.

From what I understand jsdom update requires jest to drop support for node 16 which seems like maintainer still want to support, so various previous community driven attempts to update jsdom were rejected.
Let's see, maybe something changes in that regard

@BernhardBehrendt
Copy link

I'm affected by an issue regarding CSS parsing which is related to the old jsdom version. So it would be beneficial to get this lib updated as it's actually causing tons of those errors in my unit tests.

Copy link

github-actions bot commented Mar 1, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants