-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade jsdom to latest (v26.0.0) #15481
Conversation
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
duplicate of #15473 |
Oh! Nice... I'll look into the e2e snapshots thing he mentioned |
Hmm. Is this a touchy subject? I'm trying to understand the attachment to a Node version (16) that's already reached end of life. |
From what I understand jsdom update requires jest to drop support for node 16 which seems like maintainer still want to support, so various previous community driven attempts to update jsdom were rejected. |
I'm affected by an issue regarding CSS parsing which is related to the old jsdom version. So it would be beneficial to get this lib updated as it's actually causing tons of those errors in my unit tests. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
The initial motivation for this was simply to get rid of a deprecation notice from Node v22 about
punycode
:...But ultimately, we're talking about a 4-majors-behind package... so hopefully nothing blows up.
Test plan