-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update jsdom to v26.0.0 #15473
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
527bf1d
to
7ea9a40
Compare
#15417 |
Can anyone help with the e2e snapshot tests? <3 I've never done snapshot testing before and don't know how to fix the issues. |
@andreibereczki Are you currently blocked on this? I can't see the failure locally. |
Just pointing out Node 16 support was dropped in |
@jeremy-daley-kr : well the e2e tests running on ci will prevent this pr from being merged, so i would consider that blocking.
|
Summary
Increased version of jsdom to
^26.0.0
.#15325
#15217
CVE-2024-37890
Test plan
yarn add [email protected]
yarn add @types/[email protected]
Not a big deal.
22 tests are failing > but they are failing for me on main as well. No additional tests failed after the change.