feat: Change project config from name to id #11089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopedrodcf
force-pushed
the
feat/projectconfig_from_name_to_id
branch
6 times, most recently
from
d3cbc7d
to
8d4f65d
Compare
joaopedrodcf
commented
Feb 17, 2021
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| import type {Config} from '@jest/types'; | |||
|
|
|||
| // TODO should we had the description of id that was previously name | |||
| const descriptions: {[key in keyof Config.InitialOptions]: string} = { | |||
There was a problem hiding this comment.
Should we have a description of what the id does? @SimenB
And should it be added in the docs? https://jestjs.io/docs/en/cli
If so what would be the correct description?
joaopedrodcf
changed the title
joaopedrodcf
force-pushed
the
feat/projectconfig_from_name_to_id
branch
from
8d4f65d
to
546c685
Compare
|
@SimenB can you review this? 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The objective of this MR is to close the #10013 that is one of the milestones for the jest 27
https://github.com/facebook/jest/milestone/12
Changed the jest-core configs from id to name
Close #10013
Test plan
CI passing green after the refactor