Rename ProjectConfig.name to ProjectConfig.id

[SimenB]

https://github.com/facebook/jest/blob/0e0eeed9d794fe0d6d7e84f555d9684f9e944221/packages/jest-types/src/Config.ts#L149
https://github.com/facebook/jest/blob/0e0eeed9d794fe0d6d7e84f555d9684f9e944221/packages/jest-config/src/normalize.ts#L364-L371

This isn't actually a name, it's used as an ID. We have displayName which should be used for e.g. selecting which project to run

[Devanshu24]

Could I take this up?
And just to be sure I understand it correctly the task is just to rename the name attribute to id ?

[SimenB]

Yeah, go for it! And yes, just renaming it 👍 It's used as a key here and there, but TypeScript should tell you where 🙂

[Devanshu24]

Great! I'll get right on it!

[msurekci]

Hi, can I give this a shot if you have not yet started @Devanshu24 ?

[Devanshu24]

Hey @msurekci! Sorry for not replying fast, I just wasn't able to find all the instances of id in the codebase, so ended up taking quite a bit of time.
Hope you could do it :D

[gautamsingal]

@msurekci Is this issue fixed or are you working on it? I would like to pick it up.

[GabeNedden]

Hi, first-timer here. I'd love to give this a try

[jhalak27]

@SimenB Hey, I am new here. Can I work on this?

[jeysal]

Yes, this appears to be up for grabs

[flozender]

Hi, may I take this up?

[jhalak27]

@jeysal Should I start working on this?

[jeysal]

@jhalak27 sure, have a go

[jhalak27]

Are there the only two files where changes are needed?
Also, just have to change name to id right?

[jeysal]

Haven't checked how many relevant files there are, but yeah just the name change

[jhalak27]

@jeysal I have made the changes on relevant files. The Running TypeScript compiler & ESLint is successfully but the other tests are falling as there are corresponding changes required to be done in test files. What should I do?

[joaopedrodcf]

Hey, guys noticed that this is one of the milestones for the jest 27 and also a good first issue because it was stalled since October the last try to fix this I created a new MR to fix this issue. 👋

[GabeNedden]

I'm about to get started on this task, just ran a build/ test as a baseline before I start making changes. 52 tests failed, did I do something wrong or is this a normal starting point? Thank you

[joaopedrodcf]

I started this task on here: #11089 but did not get a reply from any of the maintainers. About the unit tests it was difficult to me to make it work I don't know what I did after, while I couldn't I used the pipeline to try to validate everything was working 🤔

[GabeNedden]

This is my first time trying to contribute to something. Just making sure I understand, have you already submitted a solution to this issue? If so I think I will try finding something else to work on :)

[joaopedrodcf]

It's also my first time trying to contribute to something as big as jest.
I tried to get a reply from the maintainers from them to validate but until now didn't get any answer.
What took me more time was really the problem with the unit tests.

[Udit-takkar]

@jeysal Can I work on this issue?

[jeysal]

There were a few PRs IIRC but none finished so go ahead and tag me in it when done

[Udit-takkar]

Ok

[sameem420]

Hi, If it's still open I want to work on this issue?

[jeysal]

Hey, there's already a PR ready that will land for the next major I think

[sameem420]

Hey, there's already a PR ready that will land for the next major I think

Alright. Thanks, Tim

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.