quoting default pathToJest

[connectdotz]

this is to follow up jest-community/jest-editor-support#21:

with jest-editor-support 27.0.0 now able to pass raw pathToJest to the spawn call, users can embed escape characters or quotes when they customize jest.pathToJest and our generated default jestToPath should do the same in case there is escape sequence in user's path.

related issues:
#342
#360
#426
#489

[coveralls]

Pull Request Test Coverage Report for Build 673

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.3%) to 90.605%

---

Totals
Change from base Build 667:	1.3%
Covered Lines:	730
Relevant Lines:	805

---

💛 - Coveralls

[connectdotz]

@omjadas @stephtr @seanpoulter does any of you have a few minutes to review so we can close this issue and cut a new release soon...

[omjadas]

looks good, only thing is that the shell option should probably be removed from startRunner in JestProcess.ts

[stephtr]

I don't have it in mind, if we always use the shell, do we need nodeBinExtension on Windows?

[connectdotz]

I don't have a windows machine to verify, if it worked without, I can remove it... does it matter which shell is used? I could imagine users might want to pass their favor shell in the future...

[stephtr]

Beside the shell option it looks good to me.
Sorry by the way for being unresponsive the last few weeks.

[connectdotz]

@omjadas thanks for reminding me about the deprecated shell option, it's now fixed.

@stephtr I am glad you are back! I agree we should remove the nodeBinExtension for windows if we could, but would definitely need to test it before committing. Since I didn't have a way to verify this, I think it's best to leave it as it is until maybe you or someone else to submit a separate PR for windows.

[connectdotz]

@stephtr @omjadas is there any other change that should be considered? If not please approve otherwise Github blocks merging.

[stephtr]

I agree we should remove the nodeBinExtension for windows if we could, but would definitely need to test it before committing. Since I didn't have a way to verify this, I think it's best to leave it as it is until maybe you or someone else to submit a separate PR for windows.

That's true, especially since we already had a few issues related to that.