Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote default path to jest #522

Closed

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Nov 21, 2019

this is to follow up jest-community/jest-editor-support#21:

with jest-editor-support 27.0.0 now able to pass raw pathToJest to the spawn call, users can embed escape characters or quotes when they customize jest.pathToJest and our generated default jestToPath should do the same in case there is escape sequence in user's path.

related issues:
#342
#360
#426
#489

@coveralls
Copy link

Pull Request Test Coverage Report for Build 665

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 89.256%

Totals Coverage Status
Change from base Build 664: 0.01%
Covered Lines: 732
Relevant Lines: 817

💛 - Coveralls

@connectdotz connectdotz force-pushed the quote-default-pathToJest branch from 610b3c3 to 0bd9449 Compare November 21, 2019 02:56
@connectdotz
Copy link
Collaborator Author

replaced with #523

@connectdotz connectdotz deleted the quote-default-pathToJest branch November 21, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants