Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument for missing property repeatTableHeaders #125

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ThijsSassen
Copy link
Contributor

according to the latest Polarion api the exportDocumentToPDF function has 6 arguments:
String paperSize, String orientation, boolean fitToPageWidth, boolean generateBookmarks, boolean includeHeaderFooter, boolean repeatTableHeaders

the current implementation was missing the repeatTableHeaders argument. This PR fixes that.

@jesper-raemaekers
Copy link
Owner

What version of Polarion is that? Because 21r2 does not have repeatTableHeaders.

I was well aware at some point there would be something version specific added, but there is nothing ready for that. I'm willing to accept a PR on this, but this needs to be optionally enabled then. Perhaps a version string in the Polarion class constructor.

@ThijsSassen
Copy link
Contributor Author

@jesper-raemaekers this is on 23.04 we always use the latest version. If there is an api call to request a version we can make it depending on that version.

@jesper-raemaekers
Copy link
Owner

I've not found a nice API supported way, so that leaves me with 2 options:

  1. Let the user enter the version in the constructor
  2. Getting the version from the Polarion login page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants