Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how build is resolved without keeping a reference to project. #74

Closed
wants to merge 1 commit into from
Closed

Change how build is resolved without keeping a reference to project. #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/main/java/hudson/plugins/promoted_builds/PromotionTargetAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class PromotionTargetAction extends InvisibleAction {
private final int number;

public PromotionTargetAction(AbstractBuild<?,?> build) {
jobName = build.getParent().getFullName();
jobName = build.getProject().getFullName();
number = build.getNumber();
}

Expand All @@ -26,12 +26,10 @@ public AbstractBuild<?,?> resolve() {
}

public AbstractBuild<?,?> resolve(PromotionProcess parent) {
AbstractProject<?,?> j = parent.getOwner();
if (j==null) return null;
return j.getBuildByNumber(number);
return resolve();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what was the idea of the original method. Probably the idea was to make it static.
I'll check the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what are you referring to. Are you talking about long term plans?

}

public AbstractBuild<?,?> resolve(Promotion parent) {
return resolve(parent.getParent());
return resolve();
}
}