Change how build is resolved without keeping a reference to project. #74
Conversation
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| AbstractProject<?,?> j = parent.getOwner(); | ||
| if (j==null) return null; | ||
| return j.getBuildByNumber(number); | ||
| return resolve(); |
There was a problem hiding this comment.
I'm not sure what was the idea of the original method. Probably the idea was to make it static.
I'll check the code
There was a problem hiding this comment.
Not sure what are you referring to. Are you talking about long term plans?
|
oleg-nenashev: I had a slightly deeper look at the code of promoted-builds-plugin and I agree with your comment: "Keeping of a project is definitely a wrong thing from the data persistence perspective. It cannot be merged in the current state". Inheritance plugin when asked for a collection of JobProperties or for a specific type of property just gets one of the properties from base projects(or merges them somehow, this logic can be different for every plugin). So whenever promotion has been configured on project A it will cause problems in project B that inherits from A because the JobPropertyImpl will still have project A as owner, even though it is now in project B, technically. I will need to think about a better solution to this problem than this... So please do not merge it for now. |
Inspired by DavidTanner #51
There does not seem to be happening much in that pull request so trying to get this stuff merged.