Disable Socket to support (broken on Java 17+) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket-implementation changed fundamentally in Java 17 so the current approach does not work there any more. For now we disable support for Sockets if the fields are not available
centic9
force-pushed
the
support_for_java_17
branch
from
eba7cbc
to
0e4766b
Compare
centic9
changed the title
centic9
changed the title
timja
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not fail if fields in class SocketImpl are not available.
This is the case on Java 17+ where the implementation of Sockets was
changed fundamentally and thus the current approach does not work
any more.