Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 17 to build/test matrix #83

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Add Java 17 to build/test matrix #83

merged 1 commit into from
Mar 13, 2022

Conversation

basil
Copy link
Member

@basil basil commented Mar 12, 2022

No description provided.

@basil basil added the test label Mar 12, 2022
@basil
Copy link
Member Author

basil commented Mar 12, 2022

The recently-added AgentMainTest fails when run with Java 17. This can be reproduced locally by running mvn clean verify -Dtest=org.kohsuke.file_leak_detector.AgentMainTest with Java 17.

@centic9 Are you interested in taking a look at this? There is no rush to add Java 17 support, but I have been going through and adding Java 17 to the build/test matrix for all Jenkins core components, so it would be nice to get this one crossed off the list.

@centic9
Copy link
Member

centic9 commented Mar 13, 2022

The Socket-implementation seems to have changed a lot in Java 17, so likely file-leak detection for it would need a complete re-write for JDK 17 which is likely above what I can do.

For now we could disable support for Socket on Java 17 to allow to test for the other types of file-handle leaks.

@basil
Copy link
Member Author

basil commented Mar 13, 2022

Sounds fine to me. If you're interested in submitting a patch that disables support for socket on Java 17 and passes mvn clean verify, I'd be happy to incorporate it into this PR. No pressure though.

centic9 added a commit to centic9/file-leak-detector that referenced this pull request Mar 13, 2022
The socket-implementation changed fundamentally in Java 17
so the current approach does not work there any more.

For now we disable support for Sockets if the fields are not available

Closes jenkinsci#83
centic9 added a commit to centic9/file-leak-detector that referenced this pull request Mar 13, 2022
The socket-implementation changed fundamentally in Java 17
so the current approach does not work there any more.

For now we disable support for Sockets if the fields are not available
@centic9
Copy link
Member

centic9 commented Mar 13, 2022

I created #84, it does not check for the actual Java version, but rather gracefully degrades if Socket-support is not possible.

@basil basil merged commit 188585e into jenkinsci:master Mar 13, 2022
@basil basil deleted the java17 branch March 13, 2022 15:51
centic9 pushed a commit to centic9/file-leak-detector that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants