Don't save step context during restart #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Jan 4, 2022
| FlowExecutionOwner.Executable executable = (FlowExecutionOwner.Executable) this.run; | ||
| FlowExecutionOwner flowOwner = executable.asFlowExecutionOwner(); | ||
| if (flowOwner != null) { | ||
| node = flowOwner.get().getNode(id); |
There was a problem hiding this comment.
.get() is non null, the node is checked for null on line 121
There was a problem hiding this comment.
Oh right, I meant to say that you could consider calling getOrNull so as to fall back to TaskListener.NULL in more edge conditions. Not sure it would be helpful though.
There was a problem hiding this comment.
Ah right, done in the last commit, and simplified a bit
jglick
approved these changes
Jan 7, 2022
| FlowExecutionOwner.Executable executable = (FlowExecutionOwner.Executable) this.run; | ||
| FlowExecutionOwner flowOwner = executable.asFlowExecutionOwner(); | ||
| if (flowOwner != null) { | ||
| node = flowOwner.get().getNode(id); |
There was a problem hiding this comment.
Oh right, I meant to say that you could consider calling getOrNull so as to fall back to TaskListener.NULL in more edge conditions. Not sure it would be helpful though.
timja
force-pushed
the
dont-save-step-context
branch
from
76233b7 to
c2267a6
Compare
jglick
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 (comment)
I've tested this manually and code paths work correctly and it's no longer saved in the
build.xmlBit convoluted though =/