Pass task listener to JUnit parsing #18
Conversation
| @@ -42,13 +52,21 @@ | |||
| private final String workspace; | |||
| private final boolean keepLongStdio; | |||
| private final String glob; | |||
| private final StepContext context; | |||
There was a problem hiding this comment.
Just make sure this is not serialized to build.xml!
There was a problem hiding this comment.
Does not appear to be:
<org.jenkinsci.plugins.junitrealtimetestreporter.PipelineRealtimeTestResultAction plugin="junit-realtime-test-reporter@999999-SNAPSHOT">
<descriptions class="concurrent-hash-map"/>
<id>14</id>
<node></node>
<workspace>/Users/timja/code/jenkins/junit-realtime-test-reporter-plugin/work/workspace/junit-attachments-test_PR-8@2</workspace>
<keepLongStdio>false</keepLongStdio>
<glob>**/target/surefire-reports/TEST-*.xml</glob>
</org.jenkinsci.plugins.junitrealtimetestreporter.PipelineRealtimeTestResultAction>
There was a problem hiding this comment.
Hmm, but PipelineRealtimeTestResultAction is? Then this looks dangerous. Suggest making it transient and studying the conditions under which it might be saved.
There was a problem hiding this comment.
Hmm, but PipelineRealtimeTestResultAction is? Then this looks dangerous. Suggest making it transient and studying the conditions under which it might be saved.
There was a problem hiding this comment.
Javadoc says it's safe to save it? https://javadoc.jenkins.io/plugin/workflow-step-api/org/jenkinsci/plugins/workflow/steps/StepContext.html
There was a problem hiding this comment.
Empty results, the Junit plugin assumes it gets a non null task listener and it logs something when there's no results I think (although probably isn't annotating the methods as it's not really expected to have these methods called outside of the plugin).
There was a problem hiding this comment.
The Launcher is never used. The TaskListener you could perhaps replace with https://javadoc.jenkins.io/plugin/workflow-api/org/jenkinsci/plugins/workflow/flow/FlowExecutionOwner.html#getListener--; not ideal but it is only used in this corner case anyway.
There was a problem hiding this comment.
I'll take a look tomorrow, how do I get to the FlowExecutionOwner?
Fixes #13