[JENKINS-31462] GitHub Enterprise Servers validation #10
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| public FormValidation doCheckApiUrl(@QueryParameter String value) { | ||
| if (Util.fixEmptyAndTrim(value) == null) { | ||
| return FormValidation.error("You must specify the API URI"); | ||
| public FormValidation doCheckApiUri(@QueryParameter String apiUri) { |
There was a problem hiding this comment.
Better to add @Restricted to new Stapler methods
There was a problem hiding this comment.
@oleg-nenashev Really?
/**
* Indicates that a particular element is really deprecated and that the access to it
* is subject to the additional restrictions.
*
* <p>
* These annotations and restrictions introduced by them are enforced by the
* "access-modifier-checker" mojo.
*
* @author Kohsuke Kawaguchi
*/
There was a problem hiding this comment.
@oleg-nenashev mean Restricted.NO_EXTERNAL_USAGE (AFAIR)
There was a problem hiding this comment.
@KostyaSha Thanks. Done. /cc @oleg-nenashev
|
@recena |
|
@oleg-nenashev Add a GH Enterprise server is not related to |
|
🐝 |
|
This PR should be reverted! |
|
The changes are not in |
[JENKINS-57900] Add loggers
JENKINS-31462
downstream jenkinsci/github-api-plugin#5 (really hub4j/github-api#232)
@reviewbybees especially, @jglick