Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new method to validate the GitHub API URL #232

Merged
merged 2 commits into from
Dec 1, 2015

Conversation

recena
Copy link
Contributor

@recena recena commented Nov 15, 2015

@reviewbybees specially, @oleg-nenashev

@ghost
Copy link

ghost commented Nov 15, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Collaborator

Hm... PR builder is dead

@recena
Copy link
Contributor Author

recena commented Nov 18, 2015

@oleg-nenashev AFAIK, the test suite require local configuration. Was there a PR Builder configured in this repo?

@oleg-nenashev
Copy link
Collaborator

Yep. It has been configured on Kohsuke's beescloud account. I'm looking for it

@@ -28,7 +28,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<findbugs-maven-plugin.version>3.0.1</findbugs-maven-plugin.version>
<findbugs-maven-plugin.version>3.0.2</findbugs-maven-plugin.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to commit feature change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I'll wait to know the maintainer's opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mix 2 unrelated changes in one when it possible. FB absolutely not related to Added a new method to validate the GitHub API URL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @KostyaSha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-nenashev @KostyaSha I agree. I'll change it.

@kohsuke
Copy link
Collaborator

kohsuke commented Dec 1, 2015

I have a mixed feeling about adding more connectXyz methods, but it is indeed convenient to have some of them. Given that @recena feels strongly about having this particular convenience method, I think it's OK to have it.

I've massaged this PR somewhat by the following commit.

@recena
Copy link
Contributor Author

recena commented Dec 1, 2015

@kohsuke Thanks for your time. I left GHApiInfo in a public class because we can need adding more fields in the future. I used isApiUrlValid() because we had isCredentialValid(), I tried to follow the rules.

@recena recena deleted the ValidateApiUrl branch December 3, 2015 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants