-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new method to validate the GitHub API URL #232
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Hm... PR builder is dead |
@oleg-nenashev AFAIK, the test suite require local configuration. Was there a PR Builder configured in this repo? |
Yep. It has been configured on Kohsuke's beescloud account. I'm looking for it |
@@ -28,7 +28,7 @@ | |||
|
|||
<properties> | |||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
<findbugs-maven-plugin.version>3.0.1</findbugs-maven-plugin.version> | |||
<findbugs-maven-plugin.version>3.0.2</findbugs-maven-plugin.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to commit feature change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I'll wait to know the maintainer's opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mix 2 unrelated changes in one when it possible. FB absolutely not related to Added a new method to validate the GitHub API URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @KostyaSha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleg-nenashev @KostyaSha I agree. I'll change it.
I have a mixed feeling about adding more I've massaged this PR somewhat by the following commit. |
@kohsuke Thanks for your time. I left |
@reviewbybees specially, @oleg-nenashev