Fix for stale ghprbCommentBody values (#233/JENKINS-40802) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would still like to see this merged to master and a released. In the mean time, I will build from your fork and deploy it to your master. Thanks for this fix!!!! |
|
See also: |
samrocketman
force-pushed
the
fix-stale-comment-body
branch
from
0de302d to
a1ae342
Compare
|
I have added a comment to your change so there's additional context when looking at the source code directly. |
samrocketman
approved these changes
Jan 28, 2018
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Fix for stale ghprbCommentBody values (jenkinsci#233/JENKINS-40802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been running on our instance for several months and has the desired effect. I'm afraid there is no test for this issue included; I'm not a java programmer and wouldn't really know where to start.
--- edit from @samrocketman
Fixes #233