-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghprbCommentBody is wrong when new commits are pushed #233
Labels
Comments
This appears to be the same as https://issues.jenkins-ci.org/browse/JENKINS-40802, which contains a trivial fix. |
jmdh
pushed a commit
to jmdh/ghprb-plugin
that referenced
this issue
Apr 12, 2017
jmdh
added a commit
to jmdh/ghprb-plugin
that referenced
this issue
Apr 12, 2017
samrocketman
pushed a commit
to jmdh/ghprb-plugin
that referenced
this issue
Jan 28, 2018
samrocketman
added a commit
that referenced
this issue
Jan 28, 2018
Fix for stale ghprbCommentBody values (#233/JENKINS-40802)
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this issue
Dec 12, 2018
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this issue
Dec 12, 2018
Fix for stale ghprbCommentBody values (jenkinsci#233/JENKINS-40802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To allow retesting of only specific tests, in the case of an intermittent failure, I have added a step to a build script that checks
ghprbCommentBody
for a retest message that matches a certain pattern (e.g.retest tests1 please
). When the plugin triggers a build after aretest
comment is posted everything works fine, but if a new commit is added to the PR branch to trigger a build, theghprbCommentBody
is still set to previousretest
message used. Even if I were to add in another comment to the PR (thinking it might only be looking at the most recently comment) before pushing a new commit, theghprbCommentBody
remains set as the previousretest
message.The text was updated successfully, but these errors were encountered: