Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of PR 2187 in branch 1.24.x #2188

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Backport of PR 2187 in branch 1.24.x #2188

merged 5 commits into from
Jul 20, 2021

Conversation

olamy
Copy link
Member

@olamy olamy commented Jun 24, 2021

  • [JENKINS-60995] Fix downstream build link
  • Update to use pipeline-build-step 2.14-rc430.69345dedbb03

Description

See JENKINS-60995.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@olamy olamy added bug dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 24, 2021
stages {
stage("Sequential 1 with child in it"){
steps{
build "TestJob"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be "downstreamJob" ?

}
stage("Sequential 2 with child in it"){
steps{
build "TestJob"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

}
stage("Sequential 3 with child in it using Script"){
steps{
build "TestJob"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


find("//*[contains(text(),'Triggered Builds')]").isVisible(); // Heading for table of builds
find("//*[contains(text(),'downstreamJob')]").isVisible(); // row pointing to downstream build
}

private String getJobScript(String name) throws IOException {
return new String(IOUtils.toByteArray(getClass().getResource(DownstreamLinkTest.class.getName() + "/" + testName.getMethodName() + "." + name + ".groovy")));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dohbedoh the problem is here :) I'm fixing that especially as 1.24.x doesn't have same level of commons-io dependencies

Signed-off-by: Olivier Lamy <[email protected]>
@olamy
Copy link
Member Author

olamy commented Jul 15, 2021

Still waiting for a release of pipeline-build-step-plugin
I can't but did that jenkins-infra/repository-permissions-updater#2015

olamy added 2 commits July 19, 2021 11:27
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy merged commit 42acd6f into 1.24.x Jul 20, 2021
@olamy olamy deleted the PR-2187-branch-1.24.x branch July 20, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants