Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-pipeline-build-step +olamy #2015

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Jul 7, 2021

Signed-off-by: Olivier Lamy [email protected]

Description

as the yaml file is named plugin-pipeline-build-step.yml this PR concerns obviously plugin-pipeline-build-step

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@rsandell
Copy link
Contributor

I am a maintainer and approve this request.

@olamy
Copy link
Contributor Author

olamy commented Jul 15, 2021

@olamy

@timja timja merged commit ae1e418 into jenkins-infra:master Jul 18, 2021
@olamy olamy deleted the plugin-pipeline-build-step-olamy branch July 22, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants