Trying to make mock tests pass against Spring Security #2106

jglick · 2020-09-21T14:41:05Z

Fixes one failure when run against jenkinsci/jenkins#4848. The other two fail in

java.lang.NullPointerException
	at hudson.security.ACL.hasPermission(ACL.java:134)
	at io.jenkins.blueocean.service.embedded.rest.UserImplPermissionTest$3.answer(UserImplPermissionTest.java:130)
	at io.jenkins.blueocean.service.embedded.rest.UserImplPermissionTest$3.answer(UserImplPermissionTest.java:126)

which I do not think can be fixed without actually updating the jenkins.version, because you cannot mock

public static @NonNull Authentication getAuthentication2()

without that dep, and ACL.hasPermission(Permission) is final.

jglick · 2020-09-21T14:49:02Z

...st-impl/src/test/java/io/jenkins/blueocean/service/embedded/rest/UserImplPermissionTest.java

@@ -143,15 +149,20 @@ public Boolean answer(InvocationOnMock invocation) {
     */
    @Test
    public void useTestAgainstOrgBaseOnFolder() {
+        try { // https://github.com/powermock/powermock/issues/428


powermock/powermock#428

…lueocean-plugin#2106

jglick · 2020-09-29T13:23:31Z

@olamy this is a follow-up to #2084.

[JEP-227] jenkinsci/blueocean-plugin#2106 released

jglick added 2 commits September 21, 2020 10:33

Trying to make mock tests pass against Spring Security

4aa13e4

Hacky workaround

4932073

jglick commented Sep 21, 2020

View reviewed changes

jglick added a commit to jglick/jep that referenced this pull request Sep 21, 2020

jenkinsci/blueocean-plugin#2084 released; now moved on to jenkinsci/b…

5f56f93

…lueocean-plugin#2106

Merge branch 'master' into spring-PCT

50663ed

olamy added test maintenance labels Sep 29, 2020

olamy approved these changes Sep 29, 2020

View reviewed changes

olamy merged commit 736b18e into jenkinsci:master Sep 29, 2020

jglick deleted the spring-PCT branch September 29, 2020 22:26

jglick added a commit to jglick/jep that referenced this pull request Oct 6, 2020

[JEP-227] jenkinsci/blueocean-plugin#2106 released

9285469

oleg-nenashev added a commit to jenkinsci/jep that referenced this pull request Oct 6, 2020

Merge pull request #312 from jglick/227-blueocean

b3546b0

[JEP-227] jenkinsci/blueocean-plugin#2106 released

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trying to make mock tests pass against Spring Security #2106

Trying to make mock tests pass against Spring Security #2106

jglick commented Sep 21, 2020

jglick Sep 21, 2020

jglick commented Sep 29, 2020

Trying to make mock tests pass against Spring Security #2106

Trying to make mock tests pass against Spring Security #2106

Conversation

jglick commented Sep 21, 2020

jglick Sep 21, 2020

Choose a reason for hiding this comment

jglick commented Sep 29, 2020