Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ACL.as #2084

Merged
merged 10 commits into from
Aug 22, 2020
Merged

Use ACL.as #2084

merged 10 commits into from
Aug 22, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 4, 2020

Internal cleanup noticed while investigating uses of relatively exotic Acegi Security APIs for jenkinsci/jenkins#4848.

jglick added a commit to jglick/jep that referenced this pull request Aug 4, 2020
@jglick jglick marked this pull request as draft August 7, 2020 14:32
@jglick jglick marked this pull request as ready for review August 21, 2020 16:41
@jglick
Copy link
Member Author

jglick commented Aug 21, 2020

@olamy assuming tests pass (or at least no more fail than are already failing in master), could this be merged & released at some point? Will be helpful for finding genuine PCT regressions rather than noise.

@olamy olamy added the bug label Aug 21, 2020
@olamy olamy merged commit 4fe9b6e into jenkinsci:master Aug 22, 2020
@jglick jglick deleted the ACL.as branch August 24, 2020 12:30
@jglick
Copy link
Member Author

jglick commented Aug 24, 2020

@olamy olamy added the bug label 3 days ago

More like cleanup.

@olamy
Copy link
Member

olamy commented Aug 24, 2020

@jglick
Copy link
Member Author

jglick commented Aug 24, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants