Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of exception throwing in BitbucketCloudApiClient.java #851

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

thomas-boehm-tractive
Copy link
Contributor

Bug was introduced in #839, as discussed here #839 (review)

In order to log the exceptions, they have to be thrown. In the previous PR, all exceptions were caught by a catch block, and null was returned. This is not the behavior from the before the PR.

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

Fixes #850

@nfalco79
Copy link
Member

sound good

@nfalco79
Copy link
Member

nfalco79 commented Jun 22, 2024

@thomas-boehm-tractive please have a look to be able to merge this fix

@thomas-boehm-tractive
Copy link
Contributor Author

@thomas-boehm-tractive please have a look to be able to merge this fix

@nfalco79 have a look at what? I don't see any issues with this PR (checks succeeded, no conflicts with base branch...), what is missing in your opinion, or do you see anything I am missing?

Bug was introduced in jenkinsci#839, as discussed here jenkinsci#839 (review)
@nfalco79
Copy link
Member

For me it's ok, previous behaviour has been restored

@nfalco79
Copy link
Member

i hope that at least one of the current maintainer will take action on this PR @dwnusbaum @bitwiseman @car-roll
This PR is a really fast to review and stucks here from a very long time.

@nfalco79 nfalco79 merged commit b26cce5 into jenkinsci:master Oct 29, 2024
16 checks passed
@thomas-boehm-tractive thomas-boehm-tractive deleted the fix-eating-of-exceptions branch October 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "eating of exception" introduced in PR #839
2 participants