Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "eating of exception" introduced in PR #839 #850

Closed
thomas-boehm-tractive opened this issue May 23, 2024 · 2 comments · Fixed by #851
Closed

Fix "eating of exception" introduced in PR #839 #850

thomas-boehm-tractive opened this issue May 23, 2024 · 2 comments · Fixed by #851
Labels

Comments

@thomas-boehm-tractive
Copy link
Contributor

thomas-boehm-tractive commented May 23, 2024

Jenkins and plugins versions report

Environment
Jenkins: 2.387.3
OS: Linux - 4.14.336-257.568.amzn2.x86_64
Java: 11.0.19 - Eclipse Adoptium (OpenJDK 64-Bit Server VM)  

What Operating System are you using (both controller, and any agents involved in the problem)?

Controller running in docker

Reproduction steps

#839 introduced the issue that exceptions of the callable are no longer forwarded, but "eaten" by a try-catch block.

Expected Results

Exceptions should be thrown, as before.

Actual Results

null is returned -> no exception thrown and logged

Anything else?

No response

Are you interested in contributing a fix?

A PR will be created and linked.

@thomas-boehm-tractive
Copy link
Contributor Author

thomas-boehm-tractive commented May 23, 2024

Related to ticket #838, where this bug was introduced.

@thomas-boehm-tractive
Copy link
Contributor Author

Issue was discussed here: #839 (review)

@thomas-boehm-tractive thomas-boehm-tractive changed the title Fix "eating of exception" introduced in PR 839 Fix "eating of exception" introduced in PR #839 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant