Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bom and other archetypes to 2.303 #376

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Bump bom and other archetypes to 2.303 #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions empty-plugin/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<properties>
<revision>1.0</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.303.1</jenkins.version>
<jenkins.version>2.303.3</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never really settled jenkinsci/pipeline-maven-plugin#368 (comment) did we? https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ is still advocating .1. My personal recommendation is .latest like this, especially in this case since .3 contains https://www.jenkins.io/security/advisory/2021-11-04/.

Copy link
Member Author

@timja timja Jan 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was enforcer errors without it, a pipeline plugin requires .3.

but yeah me too

<java.level>8</java.level>
#if( $hostOnJenkinsGitHub == "true" )<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>#end
</properties>
Expand All @@ -39,8 +39,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.277.x</artifactId>
<version>961.vf0c9f6f59827</version>
<artifactId>bom-2.303.x</artifactId>
<version>1090.v0a_33df40457a_</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
6 changes: 3 additions & 3 deletions global-configuration/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<properties>
<revision>1.0</revision>
<changelist>-SNAPSHOT</changelist>
<jenkins.version>2.277.1</jenkins.version>
<jenkins.version>2.303.3</jenkins.version>
<java.level>8</java.level>
#if( $hostOnJenkinsGitHub == "true" )<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>#end
</properties>
Expand All @@ -48,8 +48,8 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.277.x</artifactId>
<version>961.vf0c9f6f59827</version>
<artifactId>bom-2.303.x</artifactId>
<version>1090.v0a_33df40457a_</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
6 changes: 3 additions & 3 deletions hello-world/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<changelist>-SNAPSHOT</changelist>

<!-- Baseline Jenkins version you use to build the plugin. Users must have this version or newer to run. -->
<jenkins.version>2.277.1</jenkins.version>
<jenkins.version>2.303.3</jenkins.version>
<java.level>8</java.level>
#if( $hostOnJenkinsGitHub == "true" )<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>#end
</properties>
Expand All @@ -51,8 +51,8 @@
<dependency>
<!-- Pick up common dependencies for the selected LTS line: https://github.com/jenkinsci/bom#usage -->
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.277.x</artifactId>
<version>961.vf0c9f6f59827</version>
<artifactId>bom-2.303.x</artifactId>
<version>1090.v0a_33df40457a_</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down