Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bom-2.277.x from 876.vc43b4c6423b6 to 950.v396cb834de1e #368

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 13, 2021

Bumps bom-2.277.x from 876.vc43b4c6423b6 to 950.v396cb834de1e.

Release notes

Sourced from bom-2.277.x's releases.

950.v396cb834de1e

🚨 Removed

  • Bump junit-attachments from 1.6 to 1.7; remove jquery and jquery-detached (#635) @​dependabot

🚀 New features and improvements

📦 Dependency updates

🚦 Tests

937.v51fde92016ed

🚀 New features and improvements

📦 Dependency updates

👻 Maintenance

924.vda78166e6655

🚀 New features and improvements

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [bom-2.277.x](https://github.com/jenkinsci/bom) from 876.vc43b4c6423b6 to 950.v396cb834de1e.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.277.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from aheritier as a code owner September 13, 2021 08:01
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 13, 2021
@aheritier
Copy link
Member

Dependency org.jenkins-ci.plugins.workflow:workflow-multibranch:jar:2.26 requires Jenkins 2.277.4 or higher.

As discussed with @jglick it seems that our recommandations are to use the .1 but it's not followed by all projects

jenkinsci/workflow-multibranch-plugin@4e6abf6 did the change from .1 to .4 cc @bitwiseman @timja (from jenkinsci/workflow-multibranch-plugin#103 )

@timja
Copy link
Member

timja commented Sep 13, 2021

Dependency org.jenkins-ci.plugins.workflow:workflow-multibranch:jar:2.26 requires Jenkins 2.277.4 or higher.

As discussed with @jglick it seems that our recommandations are to use the .1 but it's not followed by all projects

jenkinsci/workflow-multibranch-plugin@4e6abf6 did the change from .1 to .4 cc @bitwiseman @timja (from jenkinsci/workflow-multibranch-plugin#103 )

🤷 a number of projects don't, given how old this line is now bumping should be no issue.

Bugs, security issues or something else could all be reasons for using a newer base

@aheritier
Copy link
Member

yes I am not sure which baseline to use. In general I try to be at current LTS minus 2 baselines). I know it's already very old but you know how that works and I don't want to let too many users behind...

@timja
Copy link
Member

timja commented Sep 13, 2021

yes I am not sure which baseline to use. In general I try to be at current LTS minus 2 baselines). I know it's already very old but you know how that works and I don't want to let too many users behind...

I would suggest just bumping to a newer version in this line then

@jglick
Copy link
Member

jglick commented Sep 13, 2021

Since the published recommendations advise picking 2.xxx.1, perhaps the bom should attempt to enforce that using such versions in sample-plugin (after pushing through releases of all plugins currently using 2.xxx.3 and the like)? Either that or revisit jenkins-infra/jenkins.io#3643 (comment). It is a pain to have conflicting choices in upstream plugins: a downstream plugin is required to pick a baseline at least as new as that of the newest transitive dependency. CC @daniel-beck @MarkEWaite

@timja
Copy link
Member

timja commented Sep 13, 2021

Bugs happen in LTS versions, whether or not that's the reason I can't see enforcing it to be the way to go =/

and I don't think we should be enforcing it in by using those versions as otherwise we're testing against older versions rather than what we recommend people run. (we could additionally test against older but in the same LTS line seems pointless for the compute we have available)

@jglick
Copy link
Member

jglick commented Sep 13, 2021

otherwise we're testing against older versions rather than what we recommend people run

So, to be clear, do you advocate

?

@timja
Copy link
Member

timja commented Sep 13, 2021

that would be my preference yes

@jglick
Copy link
Member

jglick commented Sep 13, 2021

Care to file a PR to that effect and request review from the people involved in jenkins-infra/jenkins.io#3630 + jenkins-infra/jenkins.io#3643 + jenkins-infra/jenkins.io#3655?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 4, 2021

Superseded by #371.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants