Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable trimming in Microsoft.Toolkit.Notifications again #297

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Enable trimming in Microsoft.Toolkit.Notifications again #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89b1405
Bump Windows Community Toolkit to 7.1.3
Sergio0694 Oct 23, 2022
f3641b3
Enable trimming again for Microsoft.Toolkit.Uwp.Notifications
Sergio0694 Oct 23, 2022
c1e670c
Bump Windows Community Toolkit to stable release
Sergio0694 Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/AmbientSounds.Uwp/AmbientSounds.Uwp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,25 +656,25 @@
<Version>10.1901.28001</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.Connectivity">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.Notifications">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.UI.Animations">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.UI.Behaviors">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.UI.Controls">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.Toolkit.Uwp.UI.Media">
<Version>7.1.2</Version>
<Version>7.1.3</Version>
</PackageReference>
<PackageReference Include="Microsoft.UI.Xaml">
<Version>2.7.1</Version>
Expand Down
15 changes: 6 additions & 9 deletions src/AmbientSounds.Uwp/Properties/Default.rd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@
<Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
<Application>

<!-- Required for the toolkit's notification helpers to work in release mode -->
<Assembly Name="Microsoft.Toolkit.Uwp.Notifications" Dynamic="Required All" />

<!-- Required for signalr to work in release mode -->
<Namespace Name="Microsoft.Extensions.Options" Dynamic="Required Public"/>
<Type Name="Microsoft.AspNetCore.SignalR.JsonHubProtocolOptions" Activate="Required Public" />
<Type Name="Microsoft.Extensions.Logging.LoggerFactoryOptions" Activate="Required Public" />
<Type Name="Microsoft.Extensions.Logging.LoggerFilterOptions" Activate="Required Public" />
<Type Name="Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionOptions" Activate="Required Public" />
<!-- Required for signalr to work in release mode -->
<Namespace Name="Microsoft.Extensions.Options" Dynamic="Required Public"/>
<Type Name="Microsoft.AspNetCore.SignalR.JsonHubProtocolOptions" Activate="Required Public" />
<Type Name="Microsoft.Extensions.Logging.LoggerFactoryOptions" Activate="Required Public" />
<Type Name="Microsoft.Extensions.Logging.LoggerFilterOptions" Activate="Required Public" />
<Type Name="Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionOptions" Activate="Required Public" />
</Application>
</Directives>