Enable trimming in Microsoft.Toolkit.Notifications again #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
dev/notifications-trimming
branch
from
7ed378b to
f3641b3
Compare
|
Can you confirm notifications still work for focus sessions in release mode? |
|
Works fine 👍
|
dpaulino
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Windows Community Toolkit to 7.1.3 and enables trimming again for the notifications. This is thanks to a fix I did in CommunityToolkit/WindowsCommunityToolkit#4553 which completely removed reflection from that package, so trimming is now safe. Leaving this as a PR for now so you can also test this on your end. Will publish as soon as 7.1.3 is released as stable (should be later this week or the next).