-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variants with 100% root font size and rem values / 1.6 #80
base: main
Are you sure you want to change the base?
Add variants with 100% root font size and rem values / 1.6 #80
Conversation
dc0b3e7
to
9f2b81b
Compare
Hey @lionel-rowe Sorry for the super late response here. I'm happy to get rid of the 62.5% font sizing in the main CSS itself, no need for a variant. Can you update your PR to do it? |
@jenil Sorry, somehow I missed this comment back in 2022. I could do that, but that would be a breaking change for Chota vNext vs all previous versions (assuming most consumers use it alongside at least some of their own hand-written CSS). Is that OK? Perhaps a brief note about upgrading would suffice. |
@lionel-rowe yes that would be a new major release and accompanied with upgrade instructions. |
c83869a
to
ac2d251
Compare
7ab9293
to
017fbd5
Compare
@jenil I've made the code changes. These are generated by running postcss on the I think simply releasing chota-next as <link rel="stylesheet" href="https://unpkg.com/chota"> Given that, I'm not sure what a good upgrade path would be. |
Fixes #79. Uses a purpose-built postcss plugin,
postcss-revert-rem-size
, to create variant builds of Chota (chota.100.css
andchota.100.min.css
) that have a root font size of 100% and accordingly divide allrem
values by 1.6.Sample diff output from running
git diff HEAD:./dist/chota.css ./dist/chota.100.css
after runningyarn run build
: