Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove font-size: 62.5% hack #79

Open
lionel-rowe opened this issue Feb 4, 2022 · 1 comment · May be fixed by #80
Open

remove font-size: 62.5% hack #79

lionel-rowe opened this issue Feb 4, 2022 · 1 comment · May be fixed by #80
Assignees

Comments

@lionel-rowe
Copy link

lionel-rowe commented Feb 4, 2022

For reasons given by user @lcech on a comment on the blog post Respecting Font Size Preferences: Rems and 62.5% Base Font Size:

This is a good idea, unless it isn't. E.g. when you don't have 100% control over all the CSS on your website. Think of 3rd party components (e.g. cookie consents so popular these days, online chats, etc.), libraries like Bootstrap etc. - these sometimes expect that the root font-size is somewhat reasobanle and therefore use rem as well. But if you change the root font-size, suddenly those 3rd party components act accordingly.

It seems likely to me that the use case where Chota has to play nicely with at least some other non-user-defined CSS is going to be much more common than the use case where it doesn't.

If modifying the base library isn't feasible or desirable, perhaps an alternative build could be provided that simply divides all rem values by 1.6?

@minusf
Copy link

minusf commented Dec 4, 2024

I just found about this hack that is unfortunately not documented anywhere explicitly, although tbf I should have sat up when reading

--grid-maxWidth: 108rem; /* max container width 1080px */

Unfortunately this does not fly nowadays. Having all kinds of 3rd party widgets and stuff on the page means they are all scaled down. Are there any news on in #80 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants