Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(en-us.json): fix two english typos #546

Closed
wants to merge 1 commit into from

Conversation

ThibaultNocchi
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved way too fast

@ThibaultNocchi You sure the context here is plural?

If that's the case, we should also change the keys.

@ThibaultNocchi
Copy link
Member Author

@ferferga haha np. You can see other similar sentences are plural. On internet though, answers say both are valid, but it depends on the context (see here or here). So I'd say it's pretty safe

@camc314
Copy link
Contributor

camc314 commented Jan 13, 2021

I'd say subtitles sounds better, it's probably a good idea to change the keys as well though

@ThibaultNocchi ThibaultNocchi added the blocked Something depends on another issue or Pull Request label Jan 13, 2021
@ThibaultNocchi
Copy link
Member Author

Ok I'll do this later, I need to make it compatible with #521 as I added similar strings with similar typos.

@ThibaultNocchi
Copy link
Member Author

Gonna do it in #521 with the other strings

@ThibaultNocchi ThibaultNocchi deleted the fix/localization_typo branch January 13, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something depends on another issue or Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants