Item page improvements #521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=========================================
- Coverage 5.58% 5.23% -0.36%
=========================================
Files 97 105 +8
Lines 2702 2884 +182
Branches 420 439 +19
=========================================
Hits 151 151
- Misses 2544 2726 +182
Partials 7 7
Continue to review full report at Codecov.
|
|
Take in mind that backdrop store doesn't work in master, is fixed in #520 |
ThibaultNocchi
added
the
blocked
|
Waiting for #530 as it was rebased against. Some of the conflicts also come from there, so I don't want to do it twice :p |
this currently does what the current selectors are doing, in a more readable way to export them to this component in the next commit
ThibaultNocchi
removed
the
blocked
| @@ -42,7 +42,7 @@ | |||
| </div> | |||
| <v-row | |||
| class="mt-4 align-center" | |||
| :class="{ 'text-center': !$vuetify.breakpoint.mdAndUp }" | |||
| :class="{ 'justify-center': !$vuetify.breakpoint.mdAndUp }" | |||
| > | |||
| <v-btn | |||
| v-if="canPlay(item)" | |||
There was a problem hiding this comment.
Here we're using a v-if which calls to the mixin and a disabled which calls to local method, do these overlap? @MrTimscampi
There was a problem hiding this comment.
@ThibaultNocchi they're combined, see audio controls for an example
There was a problem hiding this comment.
You can remove the braces though
|
Kudos, SonarCloud Quality Gate passed!
|
|
I've removed the icon and now the play button gets disabled when there's no media source |
I'm trying to improve the background code of the item page.
inputevent when the track is changed with the index of the track. It also chooses the default value, disabled the selector if necessary, applies placeholders...colssmandclasstags of the two-columns lines in the info part (genres, writing, selectors...) to easily edit them later to find the right sizing 🤌