Skip to content

Commit

Permalink
test: test ignore MAC Address on restore feature
Browse files Browse the repository at this point in the history
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
  • Loading branch information
jelly committed Feb 6, 2023
1 parent 6d10327 commit 758d253
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,8 @@ class TestApplication(testlib.MachineCase):
self.filter_containers('all')

# Run a container
self.execute(True, "podman run -dit --name swamped-crate --stop-timeout 0 busybox:latest sh; podman stop swamped-crate")
mac_address = '92:d0:c6:0a:29:38'
self.execute(True, f"podman run -dit --mac-address {mac_address} --name swamped-crate --stop-timeout 0 busybox:latest sh; podman stop swamped-crate")
b.wait(lambda: self.execute(True, "podman ps --all | grep -e swamped-crate -e Exited"))

# Check that the restore option is not present (i.e. start is a regular button)
Expand Down Expand Up @@ -1257,6 +1258,12 @@ class TestApplication(testlib.MachineCase):
b.click('.pf-c-modal-box button:contains(Restore)')
b.wait(lambda: self.getContainerAttr("swamped-crate", "State") in 'Running')

# A new MAC address should have been generated
version = self.execute(False, "podman -v").strip().split(' ')[-1]
# Fixed in podman 4.4.0 https://github.com/containers/podman/issues/16666
if int(version.split('.')[0]) >= 4 and int(version.split('.')[1]) > 3:
self.assertNotEqual(self.execute(True, "podman inspect --format '{{.NetworkSettings.MacAddress}}' swamped-crate").strip(), mac_address)

# Checkpoint the container without stopping
self.waitContainerRow("swamped-crate")
self.performContainerAction("swamped-crate", "Checkpoint")
Expand Down

0 comments on commit 758d253

Please sign in to comment.