Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for container restoring with ignoring MAC address #1179

Closed
jelly opened this issue Jan 11, 2023 · 0 comments · Fixed by #1187
Closed

Add test for container restoring with ignoring MAC address #1179

jelly opened this issue Jan 11, 2023 · 0 comments · Fixed by #1187

Comments

@jelly
Copy link
Member

jelly commented Jan 11, 2023

We don't test this feature yet as it was recently broken containers/podman#16666 (Might work on podman < 4)

Basically we need a test that:

  • starts a container with a predictable MAC address using --mac-address
  • checkpoint the container
  • restore the container with the "ignore MAC address" option
  • test that the MAC != previous MAC
jelly added a commit to jelly/cockpit-podman that referenced this issue Jan 18, 2023
@jelly
test: test ignore MAC Address on restore feature
aedb3ac 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
@jelly jelly mentioned this issue Jan 18, 2023
Merged
jelly added a commit to jelly/cockpit-podman that referenced this issue Feb 6, 2023
@jelly
test: test ignore MAC Address on restore feature
758d253 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
jelly added a commit to jelly/cockpit-podman that referenced this issue Feb 7, 2023
@jelly
test: test ignore MAC Address on restore feature
6c9eded 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
jelly added a commit to jelly/cockpit-podman that referenced this issue Feb 7, 2023
@jelly
test: test ignore MAC Address on restore feature
6c90376 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
jelly added a commit to jelly/cockpit-podman that referenced this issue Feb 8, 2023
@jelly
test: test ignore MAC Address on restore feature
107e1be 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes cockpit-project#1179
martinpitt pushed a commit that referenced this issue Feb 8, 2023
@jelly @martinpitt
test: test ignore MAC Address on restore feature
19cb73d 
This was broken in 4.0 and now fixed in 4.4 which is still an release
candidate. Locally this has been tested with podman-4.4.0~rc1.

Closes #1179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: test ignore MAC Address on restore feature jelly/cockpit-podman
1 participant
@jelly