Update HTTPoison functions #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to cure dialyzer errors, update our process_response/1 function overrides to treat `headers` as a keyword list.
fastjames
force-pushed
the
elixir_18_updates
branch
from
45db598 to
0d4d341
Compare
In order to avoid conflict with the HTTPoison-provided get function and its typespec, rename `get/3` to `client_get/3`. Perform the same defensive rename for `post/3`.
According to dialyzer, (results -- seen_results) will always be a List so the second case option will never be reached. With only one option, the case statement itself is no longer needed.
fastjames
force-pushed
the
elixir_18_updates
branch
from
0d4d341 to
2016092
Compare
|
While my ultimate goal is to bring the library up to date with the latest versions for elixir and dependencies, I wanted to start with a green slate by fixing the outstanding dialyzer failures with as few changes as possible. |
|
I have a branch that brings all deps up to date and updates elixir/OTP to 1.13 / 24: https://github.com/fastjames/forcex/tree/elixir_113 . Once this PR has been merged I'll rebase that branch and open a PR on it. |
|
@jeffweiss Any chance we could get this one merged? This keeps anyone using forcex tied to a version of httpoison that's 5 years old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remain compatible with newer (as of about 1.4.0) versions of HTTPoison, update override functions in Forcex.Api.Http and in Forcex.Bulk. These functions now treat headers as a keyword list, which requires changes to the function logic.
Closes #52