Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typespec mismatch with HTTPoison.process_response/1 #52

Open
fastjames opened this issue Jun 28, 2022 · 1 comment · May be fixed by #54
Open

Typespec mismatch with HTTPoison.process_response/1 #52

fastjames opened this issue Jun 28, 2022 · 1 comment · May be fixed by #54

Comments

@fastjames
Copy link

Running mix dialyzer returns a number of errors in Forcex.Api.Http and Forcex.Bulk around the override functions for process_response/1. HTTPoison changed the signature for that function several years ago, such that headers has been changed from a Map to a kwlist. This makes the function guards (used in both locations) no longer feasible.

These functions should be updated to work with headers as a keyword list.

@fastjames
Copy link
Author

Since dialyzer has a couple of distinct errors, I wanted to document them individually here. I think I have code that's sufficient to fix this error, so I can either extract it from my current branch as its own PR or include it in a big ball of fixups.

@fastjames fastjames linked a pull request Jun 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant