-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize team split 2D example for any # of PEs #13
Generalize team split 2D example for any # of PEs #13
Conversation
Signed-off-by: David M. Ozog <[email protected]>
During the threads WG @jdinan asked whether the original example is correct for 12 PEs or more (we seem to remember that it exhibited errors at some point). @jdinan - I just checked against Sandia OpenSHMEM, and the original example works as expected with any number of PEs, as long as there are at least 12. If there were problems in the past, it is likely that they were caused by some bugs in SOS and subsequently fixed in this PR: Sandia-OpenSHMEM/SOS#920 |
@davidozog I'm on the fence. Given that the current code seems to be working, we could push this update to 1.6. Interested to hear what others think. |
@jdinan Either way is fine with me. I do think we can do better in 1.6 regardless of whether we incorporate these changes - and I'm happy to help with that. |
Section committee members @agrippa @wrrobin and @naveen-rn and @nspark what are your thoughts on this? |
Given that (1) this isn't a semantic change, (2) I think the example is still pretty easy to understand, and (3) it seems to me like an improvement in how useful and illustrative the example is, I'm in favor of merging this in 1.5. At least, I don't see any reason to defer to 1.6. Is there a downside to merging now rather than later that I'm missing? |
No downside; just being conservative on changes. Appreciate the voices of support. Let's go ahead and merge this for 1.5. @davidozog Is this ready to go? |
…menter-sec Reupdate full/partial completion to signal_wait_until
section/collectives: replace default team with world team
…rding Collectives section: fix inconsistency in calling preconditions
This proposal changes the
shmem_team_split_2D
example program to support any number of PEs (it originally supported only 12 or more PEs).It calculates the most "cube-like" configuration of
xdim
xydim
xzdim
, givennpes
.This new algorithm does not produce the same configuration as before when run with 16 PEs, so the accompanying explanation text needed to be changed. I went with 12 PEs there to simplify and take up a little less space.