Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify & cleanup the teams example programs #11
Simplify & cleanup the teams example programs #11
Changes from 5 commits
f7cd4a6
f16e72b
621399b
1f9af0e
4ce9805
d3b8242
1888810
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole example is bit convoluted for a simple team-based context and team-based PE numbering in an RMA operation. Not sure, if we can change this now:
team_3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure we can make such changes either, but if so, I'm ok with removing
team_3
. Translating to the world team is probably a more common use case. @jdinan, would this change be permissible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing teams examples sorely need attention and I fully support using section committee power to fix them. The hitch is that we need 100% consensus for any changes at this point to clear upcoming votes. Unfortunately, we're only going to get one shot at that, since these won't be read until the RC2 meeting. Here's what I propose -- let's do the best job that we can with these in advance of the RC1 meeting. @manjugv can we get some time at the end of that meeting to read these changes for feedback and ensure that they don't cause us to fail the RC2 vote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍