Simplify & cleanup the teams example programs #11
Conversation
Signed-off-by: David Ozog <[email protected]>
|
@davidozog Thanks for doing this. Let's pick up these changes for the RC2 draft. |
Add size_t and ptrdiff_t to reduction types
Signed-off-by: David M. Ozog <[email protected]>
|
@jdinan - this is ready for review, but I can't seem to add reviewers to the ticket. |
|
Working across forks is a bit of a challenge in this way. Could you create a placeholder issue on the RC2 project, link to this issue, and assign to committee members? This will also ensure this PR appears in our list of unresolved issues. Thanks! |
| if (team == SHMEM_TEAM_INVALID) { | ||
| return SHMEM_CTX_INVALID; | ||
| } | ||
| int main(void) |
There was a problem hiding this comment.
This whole example is bit convoluted for a simple team-based context and team-based PE numbering in an RMA operation. Not sure, if we can change this now:
- Can we just create one team and use the team world instead of the
team_3 - Am I missing some sort of a common usage model that the current example tries to provide?
There was a problem hiding this comment.
I'm not entirely sure we can make such changes either, but if so, I'm ok with removing team_3. Translating to the world team is probably a more common use case. @jdinan, would this change be permissible?
There was a problem hiding this comment.
The existing teams examples sorely need attention and I fully support using section committee power to fix them. The hitch is that we need 100% consensus for any changes at this point to clear upcoming votes. Unfortunately, we're only going to get one shot at that, since these won't be read until the RC2 meeting. Here's what I propose -- let's do the best job that we can with these in advance of the RC1 meeting. @manjugv can we get some time at the end of that meeting to read these changes for feedback and ensure that they don't cause us to fail the RC2 vote?
There was a problem hiding this comment.
@manjugv can we get some time at the end of that meeting to read these changes for feedback and ensure that they don't cause us to fail the RC2 vote?
👍
Signed-off-by: David M. Ozog <[email protected]>
Signed-off-by: David Ozog <[email protected]>
Co-Authored-By: James Dinan <[email protected]>
Signed-off-by: David M. Ozog <[email protected]>
|
@davidozog Any more changes planned or can we go ahead and merge? |
|
@jdinan I need to move the 2nd example from |
Signed-off-by: David M. Ozog <[email protected]>
|
@jdinan - this PR should be ready. It looks like the build failed b/c of a connection problem to ubuntu archives... not sure how to rerun it. |
List of major changes for OpenSHMEM 1.5
I've taken a stab at improving the teams example programs without changing the intent of the original examples, but there are a lot of changes. Is it possible to make these sort changes at this point, @jdinan?
PS - I apologize for not getting this posted earlier... please let me know how I can help during doc editing week!