Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing breakpoint doesn't work #50

Closed
jcward opened this issue Mar 20, 2017 · 4 comments
Closed

Removing breakpoint doesn't work #50

jcward opened this issue Mar 20, 2017 · 4 comments

Comments

@jcward
Copy link
Owner

jcward commented Mar 20, 2017

Looking at adapter.log, it appears I'm always sending AddFileLineBreakpoint commands. I need to keep a local representation of "added" breakpoints, then remove them when the list is updated.

e.g. on adding breakpoint at line 19, vscode sends me:

{"command":"setBreakpoints","arguments":{"source":{"name":"/Main.hx","path":"/home/jward/dev/vscode-hxcpp-debug/test cli/Main.hx"},"lines":[19],"breakpoints":[{"line":19}],"sourceModified":false},"type":"request","seq":24}

And I send: AddFileLineBreakpoint(Main.hx,19)

Adding on 24:

{"body":{"breakpoints":[{"verified":true,"line":19},{"verified":true,"line":24}]},"command":"setBreakpoints","success":true,"request_seq":23,"type":"response"}

And I send: AddFileLineBreakpoint(Main.hx,19) AddFileLineBreakpoint(Main.hx,24)

Then removing 24:

{"command":"setBreakpoints","arguments":{"source":{"name":"/Main.hx","path":"/home/jward/dev/vscode-hxcpp-debug/test cli/Main.hx"},"lines":[19],"breakpoints":[{"line":19}],"sourceModified":false},"type":"request","seq":24}

And I send: AddFileLineBreakpoint(Main.hx,19)

I need to maintain state and send DeleteFileLineBreakpoint.

@jcward
Copy link
Owner Author

jcward commented Mar 21, 2017

TODO: UNHANDLED MESSAGE: BreakpointStatuses(Terminator) Does hxcpp-debugger move breakpoints on invalid lines? I don't think so...

jcward added a commit that referenced this issue Mar 21, 2017
…o only mark/sweep bp's from the current file
@JohnSword
Copy link

ok it's now possible to remove the breakpoints at runtime but then it's not possible to set them back at the same line if need be.

@jcward
Copy link
Owner Author

jcward commented Mar 27, 2017

Interesting, thanks for the note @JohnSword, I'll check that out.

@jcward jcward reopened this Mar 27, 2017
@jcward jcward closed this as completed in 9d10f07 Mar 30, 2017
@jcward
Copy link
Owner Author

jcward commented Mar 30, 2017

Got it. Thanks for keeping me on my toes, @JohnSword!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants