Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step over, doesn't stop at next instruction... #49

Closed
jcward opened this issue Mar 17, 2017 · 5 comments
Closed

Step over, doesn't stop at next instruction... #49

jcward opened this issue Mar 17, 2017 · 5 comments

Comments

@jcward
Copy link
Owner

jcward commented Mar 17, 2017

Not sure if it's related to the breakpoint issue, or if it's on my end, but with the latest hxcpp (3.4.64), the step over function doesn't stop at the next line. It acts like pressing "Run" / "Continue".

@jcward
Copy link
Owner Author

jcward commented Mar 17, 2017

Note that pressing "Step Over" is like pressing "Continue" -- another breakpoint will stop it.

Also note, I'm not yet handling this "ThreadLocation" message from the debugger:

image

When pressing Step Over, the output is:

About to press step over...
1489779367.39966: Reading 70 bytes...
1489779367.39969: {"command":"next","arguments":{"threadId":0},"type":"request","seq":8}
1489779367.3997: Got command: next
1489779367.39972: ----> Sending 67 bytes:
1489779367.39973: {"command":"next","success":true,"request_seq":8,"type":"response"}
1489779367.39976: VSCH: got cmd: Next(1)
1489779367.44982: Got message: OK
1489779367.44984: ====== UNHANDLED MESSAGE: OK
1489779367.4999: Got message: ThreadStarted(0)
1489779367.54998: Got message: ThreadCreated(3)
1489779367.55: Thread 3 created.

When pressing Continue, the output is:

About to press continue...
1489779418.32282: Reading 74 bytes...
1489779418.3229: {"command":"continue","arguments":{"threadId":0},"type":"request","seq":8}
1489779418.32293: Got command: continue
1489779418.32297: VSCH: got cmd: Continue(1)
1489779418.37301: Got message: OK
1489779418.37303: ====== UNHANDLED MESSAGE: OK
1489779418.4231: Got message: ThreadStarted(0)
1489779418.42312: ----> Sending 71 bytes:
1489779418.42313: {"command":"continue","success":true,"request_seq":8,"type":"response"}
1489779418.4732: Got message: ThreadCreated(3)
1489779418.47322: Thread 3 created.

Hmm, it sure seems that I'm sending the correct messages to the debugger, lemmi try a local debugger testcase.

@jcward
Copy link
Owner Author

jcward commented Mar 17, 2017

Left a comment on the breakpoint issue -- I believe the Next command isn't being handled correctly.

@JohnSword
Copy link

hello jcward. I noticed another problem. When removing a breakpoint with the debugging session still running the breakpoint continues to break and it's not really removed (only visually in the editor). One needs to restart the app so the breakpoint is removed.

@jcward
Copy link
Owner Author

jcward commented Mar 20, 2017

Hi @JohnSword -- yes, I see this behavior also, and it looks like a bug on my end. Filed separately as #50. Thanks!

@jcward
Copy link
Owner Author

jcward commented Mar 20, 2017

The step over issue is fixed in hxcpp 3.4.69, commit 4a2fbd

@jcward jcward closed this as completed Mar 20, 2017
jcward referenced this issue in HaxeFoundation/hxcpp Mar 20, 2017
…k is made. Remove the stack context before exiting GC free zone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants