Skip to content

Commit

Permalink
(#199) Update puzzle
Browse files Browse the repository at this point in the history
  • Loading branch information
@andreoss
andreoss committed Jul 9, 2020
1 parent a0a79b2 commit d97d312
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,8 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
</dependency>
<dependency>
<!--
@todo #195:30m Migrate the rest of tests to Junit 5.
For the sake of smaller PRs, migration can be done in steps
1) Parameterized tests classes
2) Tests dependent on ExpectedException, or @Test(expected= ...)
After all tests are run by Junit 5 remove this dependency.
@todo #199:30m Migrate Junit 5 tests dependent on ExpectedException to
Junit 5. After all tests are run by Junit 5 remove this dependency.
-->
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
Expand Down

2 comments on commit d97d312

@0pdd
Copy link

@0pdd 0pdd commented on d97d312 Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 195-eea7018e disappeared from pom.xml, that's why I closed #199. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on d97d312 Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 199-1532b845 discovered in pom.xml and submitted as #206. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.