Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:151-155: Migrate the rest of tests to Junit 5.... #199

Closed
0pdd opened this issue Jul 7, 2020 · 7 comments
Closed

pom.xml:151-155: Migrate the rest of tests to Junit 5.... #199

0pdd opened this issue Jul 7, 2020 · 7 comments

Comments

@0pdd
Copy link

0pdd commented Jul 7, 2020

The puzzle 195-eea7018e from #195 has to be resolved:

jcabi-http/pom.xml

Lines 151 to 155 in 866d760

@todo #195:30m Migrate the rest of tests to Junit 5.
For the sake of smaller PRs, migration can be done in steps
1) Parameterized tests classes
2) Tests dependent on ExpectedException, or @Test(expected= ...)
After all tests are run by Junit 5 remove this dependency.

The puzzle was created by andreoss on 07-Jul-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link

0crat commented Jul 7, 2020

@yegor256/z please, pay attention to this issue

@0crat
Copy link

0crat commented Jul 7, 2020

@yegor256/z everybody who has role DEV is banned at #199; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
andreoss added a commit to andreoss/jcabi-http that referenced this issue Jul 9, 2020
@0pdd
Copy link
Author

0pdd commented Jul 9, 2020

The puzzle 195-eea7018e has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Author

0pdd commented Jul 9, 2020

@0pdd the puzzle #206 is still not solved.

@0crat
Copy link

0crat commented Jul 9, 2020

Job gh:jcabi/jcabi-http#199 is not assigned, can't get performer

@0crat 0crat removed the scope label Jul 9, 2020
@0pdd
Copy link
Author

0pdd commented Jul 10, 2020

@0pdd the puzzle #210 is still not solved; solved: #206.

@0pdd
Copy link
Author

0pdd commented Jul 25, 2020

@0pdd all 2 puzzles are solved here: #206, #210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants